On Tue, May 12, 2015 at 08:36:32AM +0200, Christoph Hellwig wrote:
> On Mon, May 11, 2015 at 04:32:37PM -0400, Brian Foster wrote:
> > > xfs_trans_unreserve_and_mod_dquots(tp);
> > > if (tp->t_ticket) {
> > > + int log_flags = 0;
> > > +
> > > + if (regrant) {
> > > + ASSERT(tp->t_flags & XFS_TRANS_PERM_LOG_RES);
> > > + log_flags = XFS_LOG_REL_PERM_RESERV;
> > > + }
> >
> > Is the regrant logic here and in xfs_log_commit_cil() backwards or am I
> > misreading?
>
> Yes, it's actually wrong, but fixed up by the next patch.
>
> I'll wait for more review feedback and will resend a fixed version.
Apart from this I can't see anything obviously wrong with this
cleanup, so if you coul dpost a fixed up version that would be
great!
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
