On Mon, May 11, 2015 at 04:32:37PM -0400, Brian Foster wrote:
> > xfs_trans_unreserve_and_mod_dquots(tp);
> > if (tp->t_ticket) {
> > + int log_flags = 0;
> > +
> > + if (regrant) {
> > + ASSERT(tp->t_flags & XFS_TRANS_PERM_LOG_RES);
> > + log_flags = XFS_LOG_REL_PERM_RESERV;
> > + }
>
> Is the regrant logic here and in xfs_log_commit_cil() backwards or am I
> misreading?
Yes, it's actually wrong, but fixed up by the next patch.
I'll wait for more review feedback and will resend a fixed version.
p.s. can you please properly quote when replying? I had to trim over 600 lines
to get to your two line comment..
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
