On Thu 13-11-14 09:34:16, Christoph Hellwig wrote: > On Tue, Nov 11, 2014 at 10:04:18PM +0100, Jan Kara wrote: > > Split ->set_xstate callback into two callbacks - one for turning quotas > > on (->sysquota_on) and one for turning quotas off (->sysquota_off). That > > way we don't have to pass quotactl command into the callback which seems > > cleaner. > > Yes, I much prefer these to be split. But the names seem a little odd, > why not enable_quota/disable_quota? I wanted to clearly separate this from quota_on() / quota_off() callbacks which are for userspace visible quota files. However enable_quota / disable_quota sound fine as well. > > +static unsigned int generic_to_xfs_flags(unsigned int uflags) > > xfs_quota_flags() ? OK. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
