Re: [PATCH 04/11] quota: Split ->set_xstate callback into two

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 11, 2014 at 10:04:18PM +0100, Jan Kara wrote:
> Split ->set_xstate callback into two callbacks - one for turning quotas
> on (->sysquota_on) and one for turning quotas off (->sysquota_off). That
> way we don't have to pass quotactl command into the callback which seems
> cleaner.

Yes, I much prefer these to be split.  But the names seem a little odd,
why not enable_quota/disable_quota?

> +static unsigned int generic_to_xfs_flags(unsigned int uflags)

xfs_quota_flags() ?

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux