On 11/13/14 11:35 AM, Mark Tinguely wrote: > On 11/12/14 12:57, Eric Sandeen wrote: >> "dirty" seems to be a remnant of unfinished code; other bits of >> it are there but commented out, so comment out "if (dirty);" as >> well, which is a no-op if statement which can't be true. >> >> Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx> >> --- >> inventory/inv_stobj.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/inventory/inv_stobj.c b/inventory/inv_stobj.c >> index becac17..84b15d9 100644 >> --- a/inventory/inv_stobj.c >> +++ b/inventory/inv_stobj.c >> @@ -976,7 +976,9 @@ stobj_delete_mobj(int fd, >> >> } >> free ( mfiles ); >> +/* >> if ( dirty ); >> +*/ >> } >> >> free ( strms ); > > Why not remove all the references to dirty in the function? > Like you said, it doesn't do anything. Somebody left this and the rest of the commented-out code there for some documentation reason, it seems, so I figured... It's not like the rest of the code is a thing of beauty, and this wart is ruining its perfection. ;) I have no idea, honestly. xfsdump is dropped in from some alien world. Somebody @ SGI might know, or could find out by looking at long-lost history? -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
