On Mon, Sep 29, 2014 at 03:43:18AM -0700, Christoph Hellwig wrote: > On Mon, Sep 29, 2014 at 11:41:26AM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > struct compat_xfs_bstat is missing the di_forkoff field and so does > > not fully translate the structure correctly. Fix it. > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > --- > > fs/xfs/xfs_ioctl32.c | 2 ++ > > fs/xfs/xfs_ioctl32.h | 3 ++- > > 2 files changed, 4 insertions(+), 1 deletion(-) > > Looks good, > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > Any chance to get an xfstests test that verifies the forkoff value? > Even if it would only reproduce this bug when running 32-bit userspace > on a 64-bit kernel it would be useful I think. There are already xfs_fsr tests that are dependent on forkoff being set to correctly defrag a file successfully. The fact that nobody has noticed that these fail tends to imply nobody runs xfstests with a 32 bit userspace on 64 bit kernels.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
