Re: [PATCH] xfs: compat_xfs_bstat does not have forkoff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 29, 2014 at 11:41:26AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> struct compat_xfs_bstat is missing the di_forkoff field and so does
> not fully translate the structure correctly. Fix it.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_ioctl32.c | 2 ++
>  fs/xfs/xfs_ioctl32.h | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Any chance to get an xfstests test that verifies the forkoff value?
Even if it would only reproduce this bug when running 32-bit userspace
on a 64-bit kernel it would be useful I think.

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux