On 4/28/14 11:35 AM, Eric Sandeen wrote: > Similar to xfs_file_fsync(), I think xfs_dir_fsync() needs > to test for a shut down fs, lest we go down paths we'll > never be able to complete; Boris reported that during some > stress tests he had threads stuck in xlog_cil_force_lsn > via xfs_dir_fsync(). (re-ping) So Dave, you fixed this with: So, you did solve the problem properly I guess, in commit ac983517ec5941da0c58cacdbad10a231dc4e001 Author: Dave Chinner <dchinner@xxxxxxxxxx> Date: Wed May 7 08:05:50 2014 +1000 xfs: don't sleep in xlog_cil_force_lsn on shutdown But should my patch still go in, if only to be consistent with file_fsync() paths? -Eric _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs