Hi folks, This is the third version of the patchset originally posted here: http://oss.sgi.com/archives/xfs/2014-04/msg00374.html This version corrects the issues that Christoph commented on in the second version. Version 3: - factored out libxfs_readbuf_verify() - LIBXFS_B_UNCHECKED flag setting/clearing cleaned up - cleaned up dirty checks on AG header scan - cleaned up error path goto stack on AG header scan - added no_modify check to remote symlink buffer bad CRC rewrite. Version 2: - move LIBXFS_B_UNCHECKED to the correct patch (patch 1) - set_cur_iotype assumes a valid type (patch 2) - comments added to explain the way LIBXFS_B_UNCHECKED and dirty buffers are supposed to interact (patch 3) - fixed comment flow and added separate "crc_error" return variable to dir_read_buf() (patch 4) - reworked CRC error handling of AG headers (patch 5) - readded missing dirty/no_modify assert (patch 6) - fixed typos (patch 8) - fixed "repair" variable initialisation flow (patch 9) - fixed dirty buffer accounting on the cursor to dirty the correct buffer on CRC errors, added some clarifying comments (patch 9) Comments and testing welcome! -Dave. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs