Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 28, 2014 at 05:22:09PM -0700, Christoph Hellwig wrote:
> >  STATIC void
> 
> needs the static removed as pointed out by Brian.
> > -	bool			read = !!(bp->b_flags & XBF_READ);
> > +	bool		read = !!(bp->b_flags & XBF_READ);
> 
> We don't really need the double negation here.

Good point. I'll fix it.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux