On Thu, Aug 28, 2014 at 05:39:11PM -0700, Christoph Hellwig wrote: > Not sure if my 10 cents are worth anything given that I haven't spent > much time with this code recently, but I feel very uneasy diverging > from the generic path in this area. I can't see how we have any other choice right now. We're caught between a rock and a hard place - XFS uses bufferheads differently to all other filesystems (esp. w.r.t. to EOF block zeroing behaviour), and so changing behaviour in the generic code to suit XFS is likely to introduce subtle data corruption bugs in other filesystems. I think the best thing we can do is move away from bufferheads in XFS. We've already got lots of hacky code to manage bufferhead/extent state coherency and so the sooner we get rid of bufferheads the sooner that crap goes away, too. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
