Re: [PATCH] common: use a relative path to fsstress

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 04, 2014 at 03:45:10AM -0700, Christoph Hellwig wrote:
> All commands run as $qa_user should use a relative path so that
> missing access permissions on $HOME for root don't prevent running
> it.  This fixes common/233 for me.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> --- a/common/config
> +++ b/common/config
> @@ -134,7 +134,7 @@ export MOUNT_PROG="`set_prog_path mount`"
>  export UMOUNT_PROG="`set_prog_path umount`"
>  [ "$UMOUNT_PROG" = "" ] && _fatal "umount not found"
>  
> -export FSSTRESS_PROG="`set_prog_path fsstress $PWD/ltp/fsstress`"
> +export FSSTRESS_PROG="./ltp/fsstress"

Why remove the set_prog_path call? i.e. this should work:

+export FSSTRESS_PROG="`set_prog_path fsstress ./ltp/fsstress`"

Otherwise, a comment explaining why set_prog_path is not used just
for this binary would be appropriate....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux