Re: [PATCH 1/2] xfsprogs: remove unused argument in trans_iput

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 30, 2014 at 09:47:50AM -0500, Eric Sandeen wrote:
> On 4/30/14, 8:48 AM, Mark Tinguely wrote:
> > Remove the unused second argument to xfs_iput() and
> > xfs_trans_iput().
> > 
> > Introduce the define "IRELE()" and use in place of xfs_iput().
> 
> Why do this?  We had been moving away from the upper-case-macro-
> redefined-to-a-function meme... what does this #define gain?
> 
> libxfs_iget/libxfs_iput pairs seem more obvious than
> libxfs_iget/IRELE()...

Mostly to match the kernel that makes it do an iput underneath..

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs




[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux