On 4/30/14, 9:50 AM, Mark Tinguely wrote: > On 04/30/14 09:47, Eric Sandeen wrote: >> On 4/30/14, 8:48 AM, Mark Tinguely wrote: >>> > Remove the unused second argument to xfs_iput() and >>> > xfs_trans_iput(). >>> > >>> > Introduce the define "IRELE()" and use in place of xfs_iput(). >> Why do this? We had been moving away from the upper-case-macro- >> redefined-to-a-function meme... what does this #define gain? >> >> libxfs_iget/libxfs_iput pairs seem more obvious than >> libxfs_iget/IRELE()... >> >> Thanks, >> -Eric >> > > To be consistent with the kernel code. Gah, hohum, I'm not even going to try to explain why I thought we didn't have it in kernel code. sorry for the noise, -Eric > --Mark. > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs