On Tue, Apr 22, 2014 at 09:35:12AM +1000, Dave Chinner wrote: > > Shouldn't we apply the same scheme as for directories here, that is if > > it fails with a verifier error re-read without the verifier and then > > still do the full check as well? > > The directory code is the special case - it uses xfs_trans_read_buf* > interfaces, which return either a good buffer with no error or an > error with no buffer. Hence for the directory code, we have to > re-read the buffer without the verifier to grab the unchecked buffer > from the cache when the verifier detects an error. How about just having a variant of xfs_da_read_buf that doesn't use xfs_trans_read_buf *? xfs_da_read_buf is pretty simple, especially when removing the magic test that has been superceeded by the verifiers. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
