Hi folks, After a conversion with a user on #IRC this morning, it was clear that xfs_repair and xfs_db weren't handling metadata blocks with CRC errors in them particularly well. xfs_metadump was reporting blocks with errors, but xfs_db was reporting them as having a correct CRC, which wasn't actually the case - they were unchecked, and the code saw the absence of error flags as meaning they were good. Repair had a similar problem - buffers that were prefetched never had the verifier run on them when they were read by the checking code as they were uptodate in the cache. Hence the prefetch code needed to mark the buffers as unchecked so that the code that checked the metadata ran the verifier and appropriately. This then showed up the fact that there were many places where repair was not catching the CRC error and rewriting the buffer to correct the bad CRC. This then showed up that we weren't actually handling remote attribute properly for the CRC enabled format. And so I fixed all of them. I've verified the code by manually corrupting blocks with xfs_db by writing garabges into unused regions of the blocks so that CRC errors are triggered. In each case repair detected the CRC error and took appropriate action. The CRC error was not found on a second run of xfs_repair. This really needs to be turned into a xfstest, but I haven't had time to do that yet. Any volunteers? Anyway, these fixes mean we'll definitely need a 3.2.0-rc2 release in the not too distant future. Comments, flames and testing all welcome.... -Dave. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
