> + switch (iocur_crc_valid()) {
> + case -1:
> + ok = "unchecked";
> + break;
> + case 0:
> + ok = "bad";
> + break;
> + case 1:
> + ok = "correct";
> + break;
> + default:
> + ok = "unknown state";
> + break;
> + }
We should have symbolic constants for these return values. But then
again iocur_crc_valid only has a single caller currently, is it even
worth the effort, or should we simply inline it?
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
