On Fri, Apr 11, 2014 at 10:12:35AM +1000, Dave Chinner wrote: > On Wed, Apr 09, 2014 at 07:49:07PM +0800, Eryu Guan wrote: > > mke2fs ext4 without extent feature will fail if 64bit feature is > > enabled in mke2fs.conf > > > > mke2fs 1.42.9 (28-Dec-2013) > > Extents MUST be enabled for a 64-bit filesystem. Pass -O extents to rectify. > > > > So disable 64bit feature together with extent explicitly. > > > > Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx> > > --- > > tests/ext4/306 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/ext4/306 b/tests/ext4/306 > > index 9559cf2..fd50b0e 100755 > > --- a/tests/ext4/306 > > +++ b/tests/ext4/306 > > @@ -48,7 +48,7 @@ _require_scratch > > rm -f $seqres.full > > > > # Make a small ext4 fs with extents disabled & mount it > > -yes | mkfs.ext4 -O ^extents $SCRATCH_DEV 512m >> $seqres.full 2>&1 > > +yes | mkfs.ext4 -O ^extents,^64bit $SCRATCH_DEV 512m >> $seqres.full 2>&1 > > _scratch_mount || _fail "couldn't mount fs" > > > > # Create a small non-extent-based file > > -- > > 1.9.0 > > Looks fine to me, but you should CC ext4 test changes to > linux-ext4@xxxxxxxxxxxxxxx as well so that the ext4 developers can > review such changes are well... Ok, will do in future. > > Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Thanks for the review. Eryu > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
