On Tue, Feb 25, 2014 at 06:07:37PM -0800, Christoph Hellwig wrote: > On Tue, Feb 25, 2014 at 08:03:20PM -0600, Eric Sandeen wrote: > > xfs_copy needs a fair bit of work for CRCs because it rewrites > > UUIDs by default, but this change will get it working properly > > with the "-d" (duplicate) option which keeps the same UUID. > > I don't think ASSERTs for user supplied data are a good idea, this > should be some real error handling. > > > However, I wonder if we should fail CRC filesystems outright > > for now if -d isn't specified, because it will invalidate every > > CRC and generally make a mess of things... > > Yeah, for now it probably should be rejected. > > It would also be useful to have a list of such issues in an README.v5 > or TODO.v5 file in the xfsprogs tree. Well, I thought we had just about got everything except for the remaining repair cleanups and the logprint failure in xfs/295 up until Eric mentioned UUIDs and xfs_copy/xfs_admin yesterday on IIRC. I can't think of anything else that is needs to be finished for a userspace release - I think that covers all the remaining xfstests failures I'm seeing on crc enabled filesystems.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
