On Mon, Feb 10, 2014 at 02:44:26AM -0800, Christoph Hellwig wrote: > On Mon, Feb 10, 2014 at 12:51:05PM +1100, Dave Chinner wrote: > > I can't say I like adding that prefix to the mkfs varaibles. I'll > > change this one to something less generic, but I'm going to ignore > > the others right now because changing them involves modifying 30+ > > tests.... > > In that case let's keep the crc one without prefix for now. But I think > introducing very generic variables into the environment implicitly is > a bad idea and will bite us long term. > > Reluctantly: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> I renamed it earlier this afternoon to "_fs_has_crc" so that code that checks it makes sense when you read it: if [ $_fs_has_crc -eq 1 ]; then ..... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
