On Fri, Nov 29, 2013 at 12:43:40PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Many of the options passed to mkfs have boolean options (0 or 1) and > all hand roll the same code and validity checks. Factor these out > into a common function. > > Note that the lazy-count option is now changed to match other > booleans in that if you don't specify a value, it reverts to the > default value (on) rather than throwing an error. Similarly the -m > crc and -n ftype options default to off rather than throwing an > error. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> Unrelated question that came up when reading through this patch: should we start deprecating some options that have long been the default, like lazy-count or attrv1? _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
