On Fri, Nov 29, 2013 at 12:43:38PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > They are horrible macros that simply obfuscate the code, so > let's factor the code and make them nice functions. > > To do this, add a sb_feat_args structure that carries around the > variables rather than a strange assortment of variables. This means > all the default can be clearly defined in a structure > initialisation, and dependent feature bits are easy to check. Nice clean, Reviewed-by: Christoph Hellwig <hch@xxxxxx> But one minor nitpick: > + bool projid16bit; Given that 32-bit projids are the newer feature I'd make them the flag instead of inverting it, which is how all the other flags work. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
