Re: [PATCH] xfs_repair: add prototype for alloc_ex_data()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 20, 2013 at 06:14:17PM -0500, Eric Sandeen wrote:
> 3ac87fbf xfsprogs: fix inode crash in xfs_repair
> 
> un-static'd alloc_ex_data and used it in phase6.c,
> but didn't put a prototype in a header, so:
> 
>  phase6.c: In function ‘mk_orphanage’:
>  phase6.c:943: warning: implicit declaration of function ‘alloc_ex_data’
> 
> Fix it...
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> diff --git a/repair/incore.h b/repair/incore.h
> index 8a578b5..38caa6d 100644
> --- a/repair/incore.h
> +++ b/repair/incore.h
> @@ -483,6 +483,11 @@ void		set_inode_parent(ino_tree_node_t *irec, int ino_offset,
>  xfs_ino_t	get_inode_parent(ino_tree_node_t *irec, int ino_offset);
>  
>  /*
> + * Allocate extra inode data
> + */
> +void		alloc_ex_data(ino_tree_node_t *irec);
> +
> +/*
>   * bmap cursor for tracking and fixing bmap btrees.  All xfs btrees number
>   * the levels with 0 being the leaf and every level up being 1 greater.
>   */

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs





[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux