Dave, On Thu, Jul 25, 2013 at 10:48:21AM +1000, Dave Chinner wrote: > On Tue, Jul 23, 2013 at 01:26:48PM -0500, Ben Myers wrote: > > On Fri, Jun 07, 2013 at 10:25:26AM +1000, Dave Chinner wrote: > > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > > > This patch mostly corresponds to commit ee1a47ab0e, and in some areas it is > > equivalent but slightly different. There are some other things in here too: > > > > * Addition of XFS_BUF_DADDR_NULL > > * rename of b_blkno to b_bn in struct xfs_buf > > * rename of b_fsprivate to b_fspriv in struct xfs_buf > > * addition of uuid_copy and uuid_equal, and libuuid to build > > > > It all looks fine to me, except as below: > > I think you'll find they are fixed up in later patches in the > series. > > Indeed, I think it's a little late to asking for these patches to be > changed, considering that making significant changes to these first > few patches will mean that I have to rebase a 100 or so subsequent > patches. You are mistaken... > For issues that aren't fixed in later patches, I'll add new patches > to the end of the current series to fix them. ...but I have no objection to taking this approach, so long as my concerns are addressed. -Ben _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
