On Wed, Jul 24, 2013 at 06:00:14PM -0500, Ben Myers wrote: > On Fri, Jun 07, 2013 at 10:25:35AM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > This addition follows the same pattern as the dir2 block CRCs. > > Seeing as both LEAF1 and LEAFN types need to changed at the same > > time, this is a pretty large amount of change. leaf block headers > > need to be abstracted away from the on-disk structures (struct > > xfs_dir3_icleaf_hdr), as do the base leaf entry locations. > > > > This header abstract allows the in-core header and leaf entry > > location to be passed around instead of the leaf block itself. This > > saves a lot of converting individual variables from on-disk format > > to host format where they are used, so there's a good chance that > > the compiler will be able to produce much more optimal code as it's > > not having to byteswap variables all over the place. > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > Looks good. Note that xfs_dir3_leafn_read_verify and > xfs_dir3_leafn_write_verify are static in the kernel but not in userspace. > > Reviewed-by: Ben Myers <bpm@xxxxxxx> corresponds to commit 24df33b45ecf5. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
