On Tue, 2013-05-14 at 04:52 -0400, Michael L. Semon wrote: Hi Michael, Thanks for testing the code and providing feedback. > Hi! I seem to have no luck in getting v8 of the pquota/uquota patchset > working and have it pass xfstests with flying colors. Is v8 of the > pquota/gquota patchset sufficient to make the new separate pquota/gquota > bits work? Or is it an incremental patchset? > > The basic functionality works, in my opinion, and I hope nobody wastes > time with a nice, educated reply. It would be mostly wasted on me and > is better saved for somebody else. A reply of "do this...and > this...btw, how did this test come out?" would be welcomed, though ;-) > > Anyway, some vague observations as I grasp for straws... > > 1) The xfstests quota group tests seem to fail in different ways than > the way they did before applying the patches. I ran the xfstests before and after these changes with the old tool chain and did not see any differences. Can you please tell me which tests failed. > > 2) Nothing has oopsed. > > 3) In testing using the `xfs_quota -x` command, the patches seem to > work. On `mount -t xfs -o gquota` mounts, using the quota command from > within the xfs_quota shell, the group quotas show but not the projid > quotas. On `mount -t xfs -o pquota` mounts, the projid quotas show but > not the gquota mounts. This is different than the old behavior, where > the gquota numbers might be recycled into projid numbers. Since we use different fields in superblock now, this should be expected. > > 4) The results of `xfsquota -c print` are confusing. Maybe they're > showing the XFS view when they show things like > 'uqnoenforce,gquota,pquota' for a mount that is gquota only. They're > doubly confusing once /etc/projid and /etc/projects have been set up. > The 'gqnoenforce' and 'pqnoenforce' flags show up at times for reasons > that are unknown to me. Can you please send me the exact commands you used. It will be good for me to test and add it to xfstests. > > 5) `mount -t xfs -o gquota,pquota` is not possible at this time. yes. you need new xfstools to make it work. > > 6) The patches applied cleanly to a git Linux 3.10-rc1 kernel + xfs-oss, > with only whitespace errors reported. > > 7) I question whether 'bsoft=' has a visible effect on projid quotas, > whether using your patches or not. Did it ever work? There are some xfstests that do test bsoft. Let me know if you think they are incorrect, we can revisit them. > > 8) I had no feel on whether the filesystem had to be mounted once as > gquota, then once as pquota, for the full dual functionality to work. No, you will be mounting filesystem as you did in (5) and it is supposed to work (wait for the new tools). > > 9) It looks like xfs_repair doesn't ruin anything, but the `xfsquota -c > print` output looks a little different on the next mount. Lets retest with tool changes. > > That's about all that could be put together in a coherent manner. Sleep > awaits. > > The PC is a 32-bit Pentium 4. In addition to the kernel mentioned in > (6), there are a few J. Liu and Dave Chinner patches applied as well. > > Best of luck! > > Michael > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
