On Mon, Feb 11, 2013 at 10:08:22AM -0500, Brian Foster wrote: > The trylock log force invoked via xfs_buf_item_push() can attempt > to acquire xa_lock, thus leading to a recursion bug when called > with xa_lock held. > > This log force was originally added to xfs_buf_trylock() to address > xfsaild stalls due to pinned and stale buffers. Since the addition > of this behavior, the log item pushing code had been reworked to > detect and track pinned items to inform xfsaild to issue a log > force itself when necessary. As such, the log force on trylock > failure is redundant and safe to remove. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
