On Mon, Dec 10, 2012 at 05:52:12AM -0500, Christoph Hellwig wrote: > On Mon, Dec 10, 2012 at 01:09:56PM +1100, Dave Chinner wrote: > > You don't use this flag anywhere ;) > > Fixed. > > > While I like most of this series, I don't really like the > > duplication of this piece of code. It seems to me that a simple > > helper like: > > I had that in a previous version, but it seemed uglier than just > opencoding it. I'll give it another try, maybe I can come up > with something nicer now. I've looked at this and it does not seem to improve the code at all, unless you have a strong objection I'm going to repost the series just with the above unused variable removed. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
