Hi Rich, Eric (2012/10/27 1:46), Rich Johnston wrote: > On 06/08/2010 03:03 PM, Eric Sandeen wrote: >> If you try running xfstests on lvm volumes which are symlinks, >> it'll fail to run several tests because our _require_scratch >> framework ultimately uses lstat not stat, and does not think >> the lvm device (which is usually a symlink to a dm-X device) >> is a block device. Sigh. >> >> Last try at this - just resolve any symlinked devicenames >> into their realpath(3) in common.config. >> >> This actually seems to work. >> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> >> >> --- >> >> >> diff --git a/common.config b/common.config >> index 926846b..e5b2483 100644 >> --- a/common.config >> +++ b/common.config > > Looks good > > Reviewed-by: Rich Johnston <rjohnston@xxxxxxx> > > Eric, > > This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f. From: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx> Commit d5ea873f is not the same as the the following original Eric's patch. http://oss.sgi.com/archives/xfs/2010-06/msg00080.html It does not modify src/Makefile and realpath is never compiled. In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0 if $TEST_DEV or $SCRATCH_DEV are not defined. Cc: Eric Sandeen <sandeen@xxxxxxxxxxx> Cc: Rich Johnston <rjohnston@xxxxxxx> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx> Reviewed-by: Wanlong Gao <gaowanlong@xxxxxxxxxxxxxx> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> Reviewed-by: Rich Johnston <rjohnston@xxxxxxx> Signed-off-by: Rich Johnston <rjohnston@xxxxxxx> --- common.config | 4 ++-- common.config | 4 ++-- src/Makefile | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Index: b/common.config =================================================================== --- a/common.config +++ b/common.config @@ -221,11 +221,11 @@ else fi # Scripts just don't deal well with symlinked devices -if [ -L $TEST_DEV ]; then +if [ -L "$TEST_DEV" ]; then TEST_DEV=`src/realpath $TEST_DEV` fi -if [ -L $SCRATCH_DEV ]; then +if [ -L "$SCRATCH_DEV" ]; then SCRATCH_DEV=`src/realpath $SCRATCH_DEV` fi Index: b/src/Makefile =================================================================== --- a/src/Makefile +++ b/src/Makefile @@ -11,7 +11,7 @@ TARGETS = dirstress fill fill2 getpagesi devzero feature alloc fault fstest t_access_root \ godown resvtest writemod makeextents itrash rename \ multi_open_unlink dmiperf unwritten_sync genhashnames t_holes \ - t_mmap_writev + t_mmap_writev realpath LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \ preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \ _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
