Re: [PATCH 21/25] xfs: add buffer pre-write callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  	/*
> +	 * run the pre-io callback function if it exists. If this function
> +	 * fails it will mark the buffer with an error and the IO should
> +	 * not be dispatched.
> +	 */
> +	if (bp->b_pre_io) {
> +		bp->b_pre_io(bp);
> +		if (bp->b_error) {

Wouldn't it be a cleaner calling convention to return the erro from the
callback?

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux