> If we have duplicate code (i.e. a copy of the upstream utility) or
> the local tool can be completely replaced by the upstream tool,
> then we should use upstream and remove the local copy completely.
> Distros have been shipping fstrim for long enough now that most
> people running testing on upstream kernels will have it installed...
>
OK, I'll create the patch which drops local version.
> Adding a _require_fstrim() function that checks for the upstream
> version of fstrim to be installed for each test that requires it
> would go along with this.
Did you mean something like
_require_fstrim()
{
which fstrim &>/dev/null || _notrun "This test requires fstrim utility."
}
in common.rc or locally in each test?
Thanks for comments!
Tomas
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
