On Mon, Jul 30, 2012 at 02:06:03PM +0200, Tomas Racek wrote: > Rename fstrim option from "-s" to "-o" and change output message when > verbose option is set. Why modify a local utility program like this? There's little point in trying to match some other utilities' command line parameters just for the sake of it... If we have duplicate code (i.e. a copy of the upstream utility) or the local tool can be completely replaced by the upstream tool, then we should use upstream and remove the local copy completely. Distros have been shipping fstrim for long enough now that most people running testing on upstream kernels will have it installed... Adding a _require_fstrim() function that checks for the upstream version of fstrim to be installed for each test that requires it would go along with this. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
