Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 29, 2012 at 05:57:28PM -0400, Christoph Hellwig wrote:
> > @@ -399,8 +399,9 @@ _xfs_buf_map_pages(
> >  	if (bp->b_page_count == 1) {
> >  		/* A single page buffer is always mappable */
> >  		bp->b_addr = page_address(bp->b_pages[0]) + bp->b_offset;
> > -		bp->b_flags |= XBF_MAPPED;
> > -	} else if (flags & XBF_MAPPED) {
> > +	} else if (flags & XBF_UNMAPPED) {
> > +		bp->b_addr = NULL;
> 
> Do we need this explicit assigned?  The buffer should always have
> b_addr == NULL at this point.

True. I'll change it to an ASSERT.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux