On Sun, Apr 29, 2012 at 05:54:20PM -0400, Christoph Hellwig wrote: > On Mon, Apr 23, 2012 at 03:59:03PM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > xfs-do-force_shutdown now is the only thing in xfs_rw.c. There is no > > need to keep it in it's own file anymore, so move it to xfs_fsops.c > > next to xfs_fs_goingdown() and kill xfs_rw.c. > > To me xfs_mount.c seems like the more reasonable place. It is not used in userspace, so rather than place it in a file that userspace shares (xfs_mount.c) and have to deal with that every merge, I moved it to a file that is not shared with userspace. Placing it with other shutdown code (xfs_fs_goingdown()) seemed like a reasonable thing to do... > Either way killing xfs_rw.c is a good thing. *nod* Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs