On Tue, Feb 21, 2012 at 08:33:22AM +1100, Dave Chinner wrote: > On Sun, Feb 19, 2012 at 09:28:19PM -0500, Christoph Hellwig wrote: > > Switch the quota code over to use the generic XFS statistics infrastructure. > > While the legacy /proc/fs/xfs/xqm and /proc/fs/xfs/xqmstats interfaces are > > preserved for now the statistics that still have a meaning with the current > > code are now also available from /proc/fs/xfs/stats. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Looks OK. Just one question/observation, though. This will make the > quota proc files show up even even quota is not compiled in. Are > there any applications out there that make use of the presence of > these files to determine if quota is configured into the kernel or > not? > > I think I just answered my own question - xfstests does exactly this > proc file test in _require_quota(). So I think their presence needs > to be conditional on CONFIG_XFS_QUOTA.... Ok, I'll respin it. That also reminds me I didn't bother to test without quotas, which I probably should do as well. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
