Re: [patch 00/12] log grant code cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 19, 2012 at 04:17:06PM -0500, Christoph Hellwig wrote:
> On Thu, Feb 16, 2012 at 03:46:09PM -0600, Ben Myers wrote:
> > On Mon, Dec 12, 2011 at 09:13:47AM -0500, Christoph Hellwig wrote:
> > > This series removes the opportunistic log space wakeups which had no
> > > use but hiding real races for far too long, and applies various bits
> > > of refactoring to the log grant code to make it smaller and more readable.
> > 
> > This patch set looks just about ready to go.  The only changes I'd like
> > to see are some commit messages where they are missing, and I have a
> > question about patch 11 related to usage t_ocnt on the log ticket.
> 
> For the "share ..." commits I can't really think of any commit message
> that actually makes sense - the subject seems to describe what the patch
> does more than enough.

It would help the reviewer if you were less terse in your commit
messages.  Not everyone is as sharp as you are.  ;)

-Ben

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux