On Fri, 2012-02-10 at 18:41 -0600, Ben Myers wrote: <snip> > > @@ -657,6 +686,7 @@ xfs_sb_to_disk( > > > > fields &= ~(1LL << f); > > } > > + from->sb_qflags = saved_qflags; > > I am disgusted that you should have to save the sb_qflags like this. > After reading this 'fields' loop in xfs_sb_to_disk along with all the > related crap I am actually feeling a little nauseous. Let me know if you have any other solutions. I am open for it. > > I don't know why in XFS we seem to feel the need to do everything in the > most complicated way possible. > > The rest of the patch looks good. > > Reviewed-by: Ben Myers <bpm@xxxxxxx> Thanks. <snip> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
