On Wed, Oct 26, 2011 at 04:21:58PM -0500, Chandra Seetharaman wrote:
> Define few macros, inline functions, and change interface in
> preparation for allowing pquota and gquota to be used together.
Looks good, but I'd really prefer to split this up further:
- one patch for adding xfs_inode_dquot
- one patch for adding XFS_IS_TYPE_QUOTA_ON
(which I'd rather make an inline and call xfs_this_quota_on)
- one for passing the mount structure to xfs_sb_from_disk
- one for the quota flags changes.
All of these also should have a good changelog, most importantly the flag
changes. If you can repost just these changes relatively soon please do
so, as I have a huge series for the quota code that should go into the
3.2 tree which I need to rebase anyway, and I'd like to do it on top of
your changes.
> - xfs_sb_t *to,
> + xfs_mount_t *mp,
> xfs_dsb_t *from)
> {
> + xfs_sb_t *to = &mp->m_sb;
> +
For code you touch please always use the struct versions instead of
the typedefs for lines you change anyway or add.
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
