Looks good. Alex, any chance to pick this one up for 3.1? Reviewed-by: Christoph Hellwig <hch@xxxxxx> On Fri, Jul 29, 2011 at 01:12:59PM +0530, Ajeet Yadav wrote: > xfs: fix for hang during synchronous buffer write error > > If removed storage while synchronous buffer write underway, > "xfslogd" hangs. > > Detailed log http://oss.sgi.com/archives/xfs/2011-07/msg00740.html > > Related work bfc60177f8ab509bc225becbb58f7e53a0e33e81 > "xfs: fix error handling for synchronous writes" > > Given that xfs_bwrite actually does the shutdown already after > waiting for the b_iodone completion and given that we actually > found that calling xfs_force_shutdown from inside > xfs_buf_iodone_callbacks was a major contributor the problem > it better to drop this call. > > Signed-off-by: Ajeet Yadav <ajeet.yadav.77@xxxxxxxxx> > > diff -Nurp -X linux/Documentation/dontdiff linux/fs/xfs/xfs_buf_item.c > linux-Dirty/fs/xfs/xfs_buf_item.c > --- linux/fs/xfs/xfs_buf_item.c 2011-06-09 10:05:18.000000000 +0530 > +++ linux-Dirty/fs/xfs/xfs_buf_item.c 2011-07-28 15:53:51.000000000 +0530 > @@ -1028,7 +1028,6 @@ xfs_buf_iodone_callbacks( > XFS_BUF_UNDELAYWRITE(bp); > > trace_xfs_buf_error_relse(bp, _RET_IP_); > - xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR); > > do_callbacks: > xfs_buf_do_callbacks(bp, lip); > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs ---end quoted text--- _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
