On Sat, Jul 16, 2011 at 11:50:14AM +1000, Dave Chinner wrote: > Bulkstat also checks for ENOENT returns from xfs_iget() as the > lookup it does is inherently racy. That is, if the inode is > allocated when it is read from the IBT, but then has been unlinked > before the actual xfs_iget() call, it expects to get back an ENOENT > to tell it the inode has been unlinked and shouldn't be included in > the bulkstat output. Otherwise, it returns the error to userspace. > > So converting the mode checks to return ESTALE definitely has the > chance of breaking stuff that uses bulkstat (e.g. xfsdump) because > it will return errors now where it previously just skipped the > (unlinked) inode. Sounds like we should simply go with the original version of the patch then. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
