On Sun, Jul 10, 2011 at 05:01:13PM -0400, Christoph Hellwig wrote: > On Tue, Jul 05, 2011 at 12:48:55PM +1000, Dave Chinner wrote: > > Folks, > > > > I pushed out an updated 2.6.38 kernel merge to xfsprogs patchset a > > couple of days ago. I've been doing quite a bit of testing on it, > > both 32 bit and 64 bit, with 512 byte, 1k and 4k block size > > filesystems and I haven't come across any regressions. The patchset > > can be found here: > > > > git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev kernel-2.6.38-sync > > > > It's pretty much unchanged from the last set of patches I sent, > > except for one minor fix to the radix tree code for an off by one in > > the path array size for item and tag deletes. > > > > I'm pretty much ready to commit this update so I can then move > > forward with updating it to the 3.0 kernel code base as a smaller > > incremental series. > > It's still missing the fix for the xfs_imap.h removal I pointed out last > round: > > Index: xfsprogs-dev/include/Makefile > =================================================================== > --- xfsprogs-dev.orig/include/Makefile 2011-07-10 20:51:24.000000000 +0000 > +++ xfsprogs-dev/include/Makefile 2011-07-10 20:51:31.000000000 +0000 > @@ -27,7 +27,7 @@ QAHFILES = libxfs.h libxlog.h \ > xfs_dir2.h xfs_dir2_block.h xfs_dir2_data.h xfs_dir2_leaf.h \ > xfs_dir2_node.h xfs_dir2_sf.h xfs_dir_leaf.h xfs_dir_sf.h \ > xfs_extfree_item.h xfs_ialloc.h xfs_ialloc_btree.h \ > - xfs_imap.h xfs_inode.h xfs_inode_item.h xfs_inum.h \ > + xfs_inode.h xfs_inode_item.h xfs_inum.h \ > xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \ > xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h xfs_trace.h \ > xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h Strangely enough I don't see that failure. Fixed, anyway. > But even after that a simple mkfs crashed for me on 32-bit x86. Here is > the gdb backtrace: > > Program received signal SIGSEGV, Segmentation fault. > 0x0805736b in tag_get (root=0xffffda5c, index=0) at radix-tree.c:82 > 82 return 1 & (((const __uint32_t *)node->tags[tag])[offset >> 5] >> (offset & 31)); > (gdb) bt > #0 0x0805736b in tag_get (root=0xffffda5c, index=0) at radix-tree.c:82 > #1 radix_tree_delete (root=0xffffda5c, index=0) at radix-tree.c:726 > #2 0x08054ee7 in libxfs_umount (mp=0xffffd8f8) at init.c:822 > #3 0x0805277c in main (argc=3, argv=0xffffdd94) at xfs_mkfs.c:2683 What size block device? It's not failing here... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
