On Mon, Apr 11, 2011 at 07:41:58PM -0400, Christoph Hellwig wrote: > On Mon, Apr 11, 2011 at 12:34:11PM +1000, Dave Chinner wrote: > > http://oss.sgi.com/archives/xfs/2010-09/msg00438.html). Firstly, > > the missing args->total was causing the initial block to be > > allocated from the freespace reserve. Secondly that the NEAR_BNO > > allocation should probably be a START_BNO allocation to allow blocks > > to be taken from a higher numbered AG. > > Looking over the use of ->total, isn't the ialloc btree code also > incorrect by setting ->total to 0? It probably is - I hadn't got that far yet. I wanted to get this tested and reviewed so test 250 would no longer assert fail everyone's debug build.... > The actual change looks good to me, > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
