On Tue, Jan 18, 2011 at 08:00:23AM -0500, Christoph Hellwig wrote: > On Wed, Jan 12, 2011 at 11:35:48AM +1100, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > The xfs_fs_mount_cmn_err() hide a simple check as to whether the > > mount path should output an error or not. Remove the macro and open > > code the check. > > I would be nice to just move the quite flag into the normal mount flags > and have a xfs_mount_warn that checks it based off the mp. Given it is a flag that is only relevant for the mount context, is there really any need to use a flag that persists for the entire life of the filesystem for it? I don't think the code is that hard to follow right now. ;) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
