On Thu, Dec 16, 2010 at 03:18:15PM -0600, Alex Elder wrote: > On Wed, 2010-12-01 at 17:06 -0500, Christoph Hellwig wrote: > > > > Merge the call to xlog_recover_reorder_trans and the loop over the > > recovery items from xlog_recover_do_trans into xlog_recover_commit_trans, > > and keep the switch statement over the log item types as a separate helper. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > I'm making a small change to this one patch though... > > + case XFS_LI_BUF: > > + return xlog_recover_do_buffer_trans(log, item, pass); > > + break; > > I have deleted this "break" statement. Yeah, this is a leftover from an earlier variant. Thanks for spotting it. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs