On Wed, 2010-12-01 at 17:06 -0500, Christoph Hellwig wrote:
>
> Merge the call to xlog_recover_reorder_trans and the loop over the
> recovery items from xlog_recover_do_trans into xlog_recover_commit_trans,
> and keep the switch statement over the log item types as a separate helper.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
I'm making a small change to this one patch though...
. . .
> @@ -2757,17 +2699,65 @@ xlog_recover_free_trans(
> }
>
> STATIC int
> +xlog_recover_commit_item(
> + struct log *log,
> + struct xlog_recover *trans,
> + xlog_recover_item_t *item,
> + int pass)
> +{
> + trace_xfs_log_recover_item_recover(log, trans, item, pass);
> +
> + switch (ITEM_TYPE(item)) {
> + case XFS_LI_BUF:
> + return xlog_recover_do_buffer_trans(log, item, pass);
> + break;
I have deleted this "break" statement.
> + case XFS_LI_INODE:
> + return xlog_recover_do_inode_trans(log, item, pass);
> + case XFS_LI_EFI:
> + return xlog_recover_do_efi_trans(log, item, trans->r_lsn, pass);
> + case XFS_LI_EFD:
> + xlog_recover_do_efd_trans(log, item, pass);
> + return 0;
. . .
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
