On Mon, Nov 29, 2010 at 11:36:41AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> With the conversion to percpu counters, xfs_icsb_modify_counters() really does
> not need to exist. Convert the inode counter modifications to use a common
> helper function for the one place that calls them, and add another function for
> the free block modification and convert all the callers to use that.
> +xfs_icsb_modify_inodes(
> + xfs_mount_t *mp,
struct xfs_mount, please.
> + int cntr,
> + int64_t delta,
> + int rsvd)
the rsvd argument isn't used at all.
> +{
> + int ret = 0;
> +
> + ASSERT(cntr == XFS_ICSB_ICOUNT || cntr == XFS_ICSB_IFREE);
> +
> + ret = xfs_icsb_add(mp, cntr, delta, 0);
> + if (ret < 0) {
> + ASSERT(0);
> + return XFS_ERROR(EINVAL);
> + }
> + return 0;
You could get rdif of the ret argument as we don't care about the
value. I also don't think we need the assert here - the caller already
does one for us.
> +xfs_icsb_modify_free_blocks(
> + xfs_mount_t *mp,
same here.
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
