Looks good to me,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
minor nitpicks below:
> int
> xlog_cil_push(
This can be marked STATIC now.
> +/*
> + * CIL force routines
> + */
> +xfs_lsn_t xlog_cil_force_lsn(struct log *log, xfs_lsn_t sequence);
> +
> +static inline void
> +xlog_cil_force(struct log *log)
> +{
> + if (log->l_cilp)
> + xlog_cil_force_lsn(log, log->l_cilp->xc_current_sequence);
> +}
I'd move the if (log->l_cilp) check to the caller. One of the two
already does so, as does the caller of xlog_cil_force_lsn.
_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs
