Re: [PATCH] xfstests: fix NIS detection damage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 06, 2010 at 11:18:39AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> NIS detection wasn't tested on machines without NIS enabled, so many tests are
> failing on non-NIS machines. the _yp_active function has no specific return
> value so always evaluates as 0 (active) and the "_cat_passwd" function is
> called from within an awk script which is not valid as the shell may run with a
> sanitised environment. Hence the functions do not need specific export calls,
> either, as unsanitised subshells will automatically inherit the parent's
> environment.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux