On Thu, Jul 15, 2010 at 10:38:17AM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > xfs_ireclaim has to get and put te pag structure because it is only > called with the inode to reclaim. The one caller of this function > already has a reference on the pag and a pointer to is, so move the > radix tree delete to the caller and remove xfs_ireclaim completely. > This avoids a xfs_perag_get/put on every inode being reclaimed. > > The overhead was noticed in a bug report at: > > https://bugzilla.kernel.org/show_bug.cgi?id=16348 Looks good, I had looked into this earlier but never finished it. There's also some opportunity to optimize roundtrips on the ilock in this path. Reviewed-by: Christoph Hellwig <hch@xxxxxx> _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
