On Thu, 2010-07-15 at 10:38 +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > xfs_ireclaim has to get and put te pag structure because it is only > called with the inode to reclaim. The one caller of this function > already has a reference on the pag and a pointer to is, so move the > radix tree delete to the caller and remove xfs_ireclaim completely. > This avoids a xfs_perag_get/put on every inode being reclaimed. > > The overhead was noticed in a bug report at: > > https://bugzilla.kernel.org/show_bug.cgi?id=16348 Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > --- > fs/xfs/linux-2.6/xfs_sync.c | 31 ++++++++++++++++++++++++- > fs/xfs/xfs_iget.c | 53 +------------------------------------------ > fs/xfs/xfs_inode.h | 2 +- > 3 files changed, 32 insertions(+), 54 deletions(-) _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs